Skip to content

Improve the direction of text, table columns, and horizontal overflow #11455

Closed
@CyRamos

Description

@CyRamos

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

Hey team,
RTL user over here.
When I grab some block of text (for example let's say it's a headline) and drag it next to another block on the left
It changes the order of the text in the wrong direction.

Wrong Example from SiYuan:

image

image

Expected result

Expected result from Notion:

image

image

Screenshot or screen recording presentation

No response

Version environment

- Version: v3.0.14
- Operating System: Windows 11 Pro
- Browser (if used): Brave, however, I'm using most with the desktop version. If it's necessary I'll use the web version.

Log file

siyuan.log

More information

No response

Activity

TCOTC

TCOTC commented on May 19, 2024

@TCOTC
Contributor

I can reproduce this

RTL.webm
CyRamos

CyRamos commented on May 19, 2024

@CyRamos
Author

I can reproduce this

RTL.webm

Hey @TCOTC
Thanks for the answer, I didn't mention however this feature is also enabled in my workspace.
image

in your video, it seems there is the same issue (when you drag the block left it appears in the right)

assigned and unassigned on May 21, 2024
CyRamos

CyRamos commented on May 22, 2024

@CyRamos
Author

Hey team
Another mention: when writing in English (General RTL enabled in Editor but in document align to left).
The punctuation is also upside down:

image
image

added this to the 3.0.16 milestone on May 23, 2024
added a commit that references this issue on May 23, 2024
changed the title [-]🐛 RTL Rearrange Blocking Do It Wrong[/-] [+]Improve the direction of text, table columns, and horizontal overflow[/+] on May 23, 2024
Vanessa219

Vanessa219 commented on May 23, 2024

@Vanessa219
Member

This is quite correct for languages written right to left: the terminating punctuation mark appears at the end, i.e. on the left.

CyRamos

CyRamos commented on May 23, 2024

@CyRamos
Author

This is quite correct for languages written right to left: the terminating punctuation mark appears at the end, i.e. on the left.

If it helps for references - in the Notion app where the blocks are auto-rotated (attach photo below)
when it's RTL or LTR it's known to rotate the block automatically.

image

Vanessa219

Vanessa219 commented on May 23, 2024

@Vanessa219
Member

Rotation may not solve the problem, RTL is also language dependent.

forabi

forabi commented on Jun 6, 2024

@forabi

Most apps which support auto-direction use some heuristics (if the paragraph starts with an RTL language character, this paragraph will be in RTL). Applying this setting to the whole editor is not very useful because most people will have to write some text in LTR languages along with RTL text in the same document.

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @88250@Vanessa219@forabi@CyRamos@TCOTC

      Issue actions

        Improve the direction of text, table columns, and horizontal overflow · Issue #11455 · siyuan-note/siyuan